From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2C0F6469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 15:46:28 +0300 (MSK)
Date: Mon, 18 May 2020 15:46:27 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200518124627.yfft7gbzju6sgplq@tarantool.org>
References: <20200512135052.221379-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200512135052.221379-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 0/7] box/console: add support for
 internal types
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

On 12 май 16:50, Cyrill Gorcunov wrote:
> In the series we implement support for internal taranool types
> such as ULL. To be able to do so we implement own serializer
> thus the output is simiar to encodings in yaml mode.
> 
> Once things settle down we will drop serpent module. I guess
> I need to explain why serpent didn't fit: there is no interface
> inside serpent to fetch internal tarantool types and adding it
> means more work to do than implement an own serializer.
> 
> v-2:
>  - address issues with achors encoding
> 
> issue https://github.com/tarantool/tarantool/issues/4682
> branch gorcunov/gh-4682-console-numbers-2
> 
> Cyrill Gorcunov (7):
>   box/console: console_session_vtab -- use designated initialization
>   box/console: use tabs instead of spaces in consolelib
>   box/console: rename format to format_yaml
>   box/console: rename luaL_yaml_default to serializer_yaml
>   box/console: implement lua serializer
>   box/console: switch to new lua serializer
>   test: extend console lua test

LGTM.

I've checked your patch into 2.4 and master.
I didn't committed it further. Maybe will do that in future.

--
Regards, Kirill Yukhin