From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D812B469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 13:01:33 +0300 (MSK)
Date: Mon, 18 May 2020 13:00:58 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200518100058.GC20053@pony.bronevichok.ru>
References: <caffa40a3ab11d147cea5ebd64048f225dd26e29.1585809264.git.avtikhon@tarantool.org>
 <20200402154444.GA8132@pony.bronevichok.ru>
 <20200515170409.GA10228@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200515170409.GA10228@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v1] Divide test box/net.box
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi, Alexander

On 20:04 Fri 15 May , Alexander V. Tikhonov wrote:
> Hi Sergey, thanks a lot for the review. As we discussed the ability to
> reproduce the issues on the fixing commits I've checked group of tests:
> 10 tests as you asked in the issue and 3 that I've already checked.
> Whithin these tests results were:
> 3 tests: all reproduced the issue
> 10 tests:
>   4 - reproduced the issue
>   1 - didn't show the issue

could you reproduce issue using original test with source code without fix?

>   5 - couldn't build and test too old fixes committed in 1.6 Tarantool
>   version.

could you reproduce them using tarantool from packages?

> To see the results with names please check the issue in github, where
> I've created the table of results for the checked tests.
> 
> On Thu, Apr 02, 2020 at 06:44:44PM +0300, Sergey Bronnikov wrote:
> > Hello!
> > 
> > before splitting test we had a net.box.skipcond file due to an issue
> > https://github.com/tarantool/tarantool/issues/4271. I believe that file
> > is useless now and we should add similar files for a new tests.
> > 
> > I have looked on tests without postfix "gh-xxx" in a filenames.
> > LGTM for them:
> > 
> > net.box_connect_triggers.test.lua
> > net.box_permissions.test.lua
> > net.box_reconnect_after.test.lua
> > net.box_get_connection_object.test.lua
> > 
> > I propose to run tests with postfix "gh-xxx" in filenames on commits
> > before fix where bug covered by test was added. Broken test would mean
> > it still works.
> > 
> > Sergey
> > 

<snipped>