From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BD68F469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 18 May 2020 12:00:46 +0300 (MSK)
Date: Mon, 18 May 2020 12:00:11 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200518090010.GA20053@pony.bronevichok.ru>
References: <1589700958.836016889@f506.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1589700958.836016889@f506.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: integration testing
	vshard
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hi, Oleg

just a curious - why you didn't add vshard tests to test/ dir in tarantool
to be able to run them using usual test-run.py?

Sergey

On 10:35 Sun 17 May , Oleg Piskunov wrote:
> 
>  
> - Adding new stage "integr_test" for integration
>   testing connectors and modules with Tarantool.
> - Addign module VSHARD for testing in Tarantool
>   development cycle.
>  
> Closes #4972
> ---
>  
> Github:  https://github.com/tarantool/tarantool/tree/opiskunov/gh-4972-integration-test-vshard
> Issue:  https://github.com/tarantool/tarantool/issues/4972
> 
>  .gitlab-ci.yml | 11 +++++++++++
>  .travis.mk     | 10 ++++++++++
>  2 files changed, 21 insertions(+)
>  
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 256b368..8576f91 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,5 +1,6 @@
>  stages:
>    - test
> +  - integr_test
>    - perf
>    - cleanup
>  
> @@ -183,6 +184,16 @@ freebsd_12_release:
>    script:
>      - ${GITLAB_MAKE} vms_test_freebsd
>  
> +# ###################
> +# Integration testing
> +# ###################
> +
> +release_module_vshard_test:
> +  <<: *docker_test_definition
> +  stage: integr_test
> +  script:
> +    - ${GITLAB_MAKE} test_module_vshard
> +
>  # ####
>  # Perf
>  # ####
> diff --git a/.travis.mk b/.travis.mk
> index 063537f..25e0469 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -87,6 +87,16 @@ test_debian: deps_debian test_debian_no_deps
>  
>  test_debian_clang8: deps_debian deps_buster_clang_8 test_debian_no_deps
>  
> +# Integration testing
> +
> +test_module_vshard:
> +       cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON -DENABLE_DIST=ON ${CMAKE_EXTRA_PARAMS}
> +       make -j
> +       make install
> +       git clone https://github.com/tarantool/vshard.git tarantool/vshard
> +       cd tarantool/vshard && git submodule update --init --recursive \
> +               && cmake . && make test
> +
>  # Debug with coverage
>  
>  build_coverage_debian:
> --
> 1.8.3.1