From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0F228469710 for ; Mon, 18 May 2020 11:45:06 +0300 (MSK) Date: Mon, 18 May 2020 11:45:06 +0300 From: Kirill Yukhin Message-ID: <20200518084506.xjj5yfxnkl6duqsf@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/1] session: deprecate box.session.push() 'sync' List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hello, On 04 май 23:43, Vladislav Shpilevoy wrote: > box.session.push() has two parameters - data to push and 'sync'. > The sync is a request ID with which the out of bound data should > be pushed into a socket. > > This was introduced as a workaround for #3450, and is useless > since its resolution. > > A user anyway can't push to different sessions, where that > parameter could be useful. And pushing into requests of the same > session, on the contrary, is something not really needed anywhere, > not portable to non-binary session types (console, background), > and is just dangerous since it is easy to add a bug here. > > The patch makes the parameter deprecated. Now on its usage there > will be a rate limited warning in the logs. > > Part of #4689 I've checked your patch into 2.4. -- Regards, Kirill Yukhin