From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1F123469710
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 17 May 2020 15:34:37 +0300 (MSK)
Date: Sun, 17 May 2020 15:34:35 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200517123435.GB17304@hpalx>
References: <1589612182.887817168@f503.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1589612182.887817168@f503.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v2] gitlab-ci: parallelize perf
	testing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Oleg, thanks for the patch. LGTM.

On Sat, May 16, 2020 at 09:56:22AM +0300, Oleg Piskunov wrote:
>=20
> =A0
> - Adding 2 servers (sh1, sh2) for performance testing.
> - Rebalance performance testing between servers:
> =A0 - sh1 (tag: docker_sh1_perf) used for benches:
> =A0 =A0 nosqlbench_hash, nosqlbench_tree
> =A0 - sh2 (tag: docker_sh2_perf) used for benches:
> =A0 =A0 ycsb_hash, ycsb_tree, cbench
> =A0 - sh3 (tag: docker_sh3_perf) used for benches:
> =A0 =A0 sysbench, tpcc
> =A0 - sh9 (tag: docker_perf_ssd) used for benches:
> =A0 =A0 linkbench_ssd
> - Changing gitlab-ci tag for performance docker images
> =A0 from 'perf' to 'deploy'.
> =A0
> Closes #4868
> ---
> =A0
> Github:  https://github.com/tarantool/tarantool/tree/opiskunov/gh-4868-pa=
rallel-perf
> Issue:  https://github.com/tarantool/tarantool/issues/4868
>=20
> =A0.gitlab-ci.yml | 18 +++++++++++++++---
> =A01 file changed, 15 insertions(+), 3 deletions(-)
> =A0
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c7f58b9..fc214ef 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -91,8 +91,6 @@ variables:
> =A0 =A0<<: *perf_only_definition
> =A0 =A0image: ${IMAGE_PERF_BUILT}
> =A0 =A0stage: perf
> - =A0tags:
> - =A0 =A0- docker_perf
> =A0 =A0artifacts:
> =A0 =A0 =A0when: always
> =A0 =A0 =A0paths:
> @@ -191,7 +189,7 @@ perf_bootstrap:
> =A0 =A0<<: *perf_only_definition
> =A0 =A0stage: test
> =A0 =A0tags:
> - =A0 =A0- perf
> + =A0 =A0- deploy
> =A0 =A0script:
> =A0 =A0 =A0- ${GITLAB_MAKE} perf_prepare
> =A0
> @@ -199,18 +197,24 @@ perf_bootstrap:
> =A0
> =A0perf_sysbench:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh3_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'sysbench'
> =A0
> =A0perf_tpcc:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh3_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'tpcc'
> =A0
> =A0perf_ycsb_hash:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh2_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'ycsb'
> @@ -218,6 +222,8 @@ perf_ycsb_hash:
> =A0
> =A0perf_ycsb_tree:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh2_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'ycsb'
> @@ -225,6 +231,8 @@ perf_ycsb_tree:
> =A0
> =A0perf_nosqlbench_hash:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh1_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'nosqlbench'
> @@ -232,6 +240,8 @@ perf_nosqlbench_hash:
> =A0
> =A0perf_nosqlbench_tree:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh1_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'nosqlbench'
> @@ -239,6 +249,8 @@ perf_nosqlbench_tree:
> =A0
> =A0perf_cbench:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh2_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'cbench'
> --
> 1.8.3.1
> =A0