From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 25E78469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 15 May 2020 18:11:16 +0300 (MSK)
Date: Fri, 15 May 2020 18:11:15 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200515151115.lldsqjolk23l4dfk@tarantool.org>
References: <d1baa7ecf136ffd60090aecdf9a081f2f9c6e607.1588358637.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d1baa7ecf136ffd60090aecdf9a081f2f9c6e607.1588358637.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] test: make app-tap/init_script
 produce less diff
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 01 май 20:45, Vladislav Shpilevoy wrote:
> When a new option is added, app-tap/init_script
> outputs big diff. Because all options are printed with
> ordinal indexes. Addition of a new option changes
> indexes of all options after the new one.
> 
> The patch removes indexes from the output making diff
> smaller, when a new option is added.
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/app-tap/init_script-test-diff
> 
> The patch is motivated by forthcoming option
> replication_sync_quorum. When I added, it produced diff about 25
> lines in this test. After the patch it becomes 1.
> 
>  test/app-tap/init_script.result   | 96 +++++++++++++++----------------
>  test/app-tap/init_script.test.lua |  2 +-
>  2 files changed, 49 insertions(+), 49 deletions(-)

LGTM.

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin