From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BD97C469710 for ; Fri, 15 May 2020 17:37:18 +0300 (MSK) Date: Fri, 15 May 2020 17:37:17 +0300 From: Kirill Yukhin Message-ID: <20200515143717.iiy7s5ukecsjycsh@tarantool.org> References: <20200420131115.42047-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200420131115.42047-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 20 апр 16:11, Serge Petrenko wrote: > Since the anonymous replica implementation, it was forbidden to > replicate (join/subscribe/register) from anonymous instances. > Actually, only joining and register should be banned. Anonymous replica > isn't able to register its peer in _cluster anyway. > Allow subscribing to anonymous instances and remove all the errors > mentioning unsupported replication from anonymous replica. Join and > register are covered by ER_READONLY errors, since anonymous replicas > must be read-only. > > Closes #4696 > --- > https://github.com/tarantool/tarantool/tree/sp/gh-4696-anon-replica-follow > https://github.com/tarantool/tarantool/issues/4696 > > There's one open question: should we allow 'normal' instances to follow > anonymous instances? The current patch implementation allows this. > I see one possible use for allowing normal instances to follow anonymous ones: > in case such an anonymous instance can be failed over to with its transition to > master. Then it would be better if all the cluster members followed it in > advance, to instantly start receiving changes from it when it becomes 'normal' > and read-write. > > @ChangeLog: > - Allow anonymous replicas to be followed by other ones (gh-4696). I've checked your patch into master. -- Regards, Kirill Yukhin