From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8F014469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 14 May 2020 13:43:55 +0300 (MSK)
Date: Thu, 14 May 2020 13:43:29 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200514104329.GB22063@pony.bronevichok.ru>
References: <2ad8677044f4a2eac3ec7ae3479dbebe09ea3f15.1589452096.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2ad8677044f4a2eac3ec7ae3479dbebe09ea3f15.1589452096.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: disable perf tesing
	in schedulled runs
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Alexander, thanks for the patch.
Please fix typo in commit message: schedulled -> scheduled.

LGTM

On 13:29 Thu 14 May , Alexander V. Tikhonov wrote:
> Release branches should be regularly run using gitlab-ci pipeline
> schedules:
>   https://gitlab.com/tarantool/tarantool/pipeline_schedules
> It will help to detect flaky issues. But there is no need to rerun
> too long running performance testing, to block it in schedules the
> option 'schedules' in 'except:' field was set.
> 
> Part of #4974
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/schedule_except_perf
> Issue: https://github.com/tarantool/tarantool/issues/4974
> 
>  .gitlab-ci.yml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index c7f58b98d..256b368c4 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -32,6 +32,8 @@ variables:
>    only:
>      - master
>      - /^.*-perf$/
> +  except:
> +    - schedules
>    variables: &perf_vars_definition
>      IMAGE_PERF: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf/ubuntu-bionic:perf_master"
>      IMAGE_PERF_BUILT: "${CI_REGISTRY}/${CI_PROJECT_PATH}/perf_tmp/ubuntu-bionic:perf_${CI_COMMIT_SHORT_SHA}"
> -- 
> 2.17.1