From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0F9BE469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 13 May 2020 21:48:33 +0300 (MSK)
Date: Wed, 13 May 2020 21:48:31 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200513184831.GA1208@hpalx>
References: <1588928284.299581840@f558.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1588928284.299581840@f558.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: parallelize perf
	testing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Oleg, thanks for the patch. As I see you set the 2 new names for the
new tags, it ok. But you removed the default name from template and set
the rest tag with its default name, I think it's better to set this tag
in the new style, like docker_sh3_perf, otherwise better to avoid of
removement of the default value from template, and in this way no need
to set it manually to depend jobs. After this correction (choose any of
two described above) LGTM.

On Fri, May 08, 2020 at 11:58:04AM +0300, Oleg Piskunov wrote:
>=20
>=20
> - Adding 2 servers (sh1, sh2) for performance testing.
> =A0 Additional gitlab-ci tags for perf testing:
> =A0 docker_sh1_perf and docker_sh2_perf.
> - Rebalance performance testing between servers.
> - Changing gitlab-ci tag for performance docker images
> =A0 from 'perf' to 'deploy'.
> =A0
> Closes #4868
> ---
> =A0
> Github: https://github.com/tarantool/tarantool/tree/opiskunov/gh-4868-par=
allel-perf
> Issue:  https://github.com/tarantool/tarantool/issues/4868
> =A0
> =A0.gitlab-ci.yml | 18 +++++++++++++++---
> =A01 file changed, 15 insertions(+), 3 deletions(-)
> =A0
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ae2afce..897f657 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -91,8 +91,6 @@ variables:
> =A0 =A0<<: *perf_only_definition
> =A0 =A0image: ${IMAGE_PERF_BUILT}
> =A0 =A0stage: perf
> - =A0tags:
> - =A0 =A0- docker_perf
> =A0 =A0artifacts:
> =A0 =A0 =A0when: always
> =A0 =A0 =A0paths:
> @@ -195,7 +193,7 @@ perf_bootstrap:
> =A0 =A0<<: *perf_only_definition
> =A0 =A0stage: test
> =A0 =A0tags:
> - =A0 =A0- perf
> + =A0 =A0- deploy
> =A0 =A0script:
> =A0 =A0 =A0- ${GITLAB_MAKE} perf_prepare
> =A0
> @@ -203,18 +201,24 @@ perf_bootstrap:
> =A0
> =A0perf_sysbench:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'sysbench'
> =A0
> =A0perf_tpcc:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'tpcc'
> =A0
> =A0perf_ycsb_hash:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh2_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'ycsb'
> @@ -222,6 +226,8 @@ perf_ycsb_hash:
> =A0
> =A0perf_ycsb_tree:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh2_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'ycsb'
> @@ -229,6 +235,8 @@ perf_ycsb_tree:
> =A0
> =A0perf_nosqlbench_hash:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh1_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'nosqlbench'
> @@ -236,6 +244,8 @@ perf_nosqlbench_hash:
> =A0
> =A0perf_nosqlbench_tree:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh1_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'nosqlbench'
> @@ -243,6 +253,8 @@ perf_nosqlbench_tree:
> =A0
> =A0perf_cbench:
> =A0 =A0<<: *perf_docker_test_definition
> + =A0tags:
> + =A0 =A0- docker_sh2_perf
> =A0 =A0variables:
> =A0 =A0 =A0<<: *perf_vars_definition
> =A0 =A0 =A0BENCH: 'cbench'
> --
> 1.8.3.1
> =A0