From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5D2CB469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 13 May 2020 17:40:39 +0300 (MSK)
Date: Wed, 13 May 2020 17:40:14 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200513144014.GA76690@pony.bronevichok.ru>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <f0a3462530fc6ab517cc8bd8569d3620bc5b48eb.1589275364.git.sergeyb@tarantool.org>
 <20200513141520.GA31843@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200513141520.GA31843@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static
	analysis with luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi, Alexander!

thanks for review.

On 17:15 Wed 13 May , Alexander V. Tikhonov wrote:

<snipped>

> > +# ###################
> > +# Static Analysis
> > +# ###################
> > +
> > +test_debian_docker_luacheck:
> > +	docker run -w ${OOS_SRC_PATH} -v ${PWD}:${OOS_SRC_PATH} --privileged --cap-add=sys_nice \
> > +		--network=host -i registry.gitlab.com/tarantool/tarantool/testing/debian-stretch:latest \
> 
> May be better to split lines to make them not longer than 80 characters.
> Also let's move the image name to the top of the file at the
> environment variable.

Updated in a branch.

<snipped>