From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 55D35469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 13 May 2020 17:15:22 +0300 (MSK)
Date: Wed, 13 May 2020 17:15:20 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200513141520.GA31843@hpalx>
References: <cover.1589275364.git.sergeyb@tarantool.org>
 <f0a3462530fc6ab517cc8bd8569d3620bc5b48eb.1589275364.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0a3462530fc6ab517cc8bd8569d3620bc5b48eb.1589275364.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 02/10] gitlab-ci: enable static
	analysis with luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi Sergey, thanks for the patch, just minor suggestion on your
discretion below, LGTM.

On Tue, May 12, 2020 at 12:49:55PM +0300, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #4681
> ---
>  .gitlab-ci.yml | 11 +++++++++++
>  .travis.mk     | 17 +++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index b3b07dac5..9c4ca57cf 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -1,4 +1,5 @@
>  stages:
> +  - static_analysis
>    - test
>    - perf
>    - cleanup
> @@ -96,6 +97,16 @@ variables:
>    script:
>      - ${GITLAB_MAKE} perf_run
>  
> +# Static Analysis
> +
> +luacheck:
> +  <<: *docker_test_definition
> +  stage: static_analysis
> +  tags:
> +    - deploy_test
> +  script:
> +    - ${GITLAB_MAKE} test_debian_docker_luacheck
> +
>  # Tests
>  
>  release:
> diff --git a/.travis.mk b/.travis.mk
> index 8aa0e6116..3c8e627d0 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -6,6 +6,8 @@ DOCKER_IMAGE?=packpack/packpack:debian-stretch
>  TEST_RUN_EXTRA_PARAMS?=
>  MAX_FILES?=65534
>  MAX_PROC?=2500
> +LANES_ROCKSPEC="https://luarocks.org/manifests/benoitgermain/lanes-3.13.0-0.rockspec"
> +OOS_SRC_PATH="/source"
>  
>  all: package
>  
> @@ -146,6 +148,21 @@ test_static_build: deps_debian_static
>  test_static_docker_build:
>  	docker build --no-cache --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
>  
> +# ###################
> +# Static Analysis
> +# ###################
> +
> +test_debian_docker_luacheck:
> +	docker run -w ${OOS_SRC_PATH} -v ${PWD}:${OOS_SRC_PATH} --privileged --cap-add=sys_nice \
> +		--network=host -i registry.gitlab.com/tarantool/tarantool/testing/debian-stretch:latest \

May be better to split lines to make them not longer than 80 characters.
Also let's move the image name to the top of the file at the
environment variable.

> +		make -f .travis.mk test_debian_luacheck
> +
> +test_debian_luacheck:
> +	apt update -y
> +	apt install -y lua5.1 luarocks
> +	luarocks install luacheck
> +	luacheck --codes --config .luacheckrc .
> +
>  #######
>  # OSX #
>  #######
> -- 
> 2.23.0
>