From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
 [209.85.167.67])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 66829469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 12 May 2020 20:31:39 +0300 (MSK)
Received: by mail-lf1-f67.google.com with SMTP id h26so11266999lfg.6
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 12 May 2020 10:31:39 -0700 (PDT)
Date: Tue, 12 May 2020 20:31:35 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200512173135.GB2219@grain>
References: <20200508114714.426908-1-gorcunov@gmail.com>
 <7d39ce8a-3c12-a814-9bb3-8d43bfc6f782@tarantool.org>
 <20200508161910.GC51428@grain>
 <88CA17D1-8D58-4FDC-9547-19D99C54DA39@corp.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <88CA17D1-8D58-4FDC-9547-19D99C54DA39@corp.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH 0/7] box/console: add support for
 internal types
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mons Anderson <v.perepelitsa@corp.mail.ru>
Cc: tarantool-patches@dev.tarantool.org

On Tue, May 12, 2020 at 08:06:07PM +0300, Mons Anderson wrote:
> >> I'm not sure that we should return errors in such way:
> >> ```
> >> tarantool> x
> >> {error = "[string \"return x\"]:1: variable \'x\' is not declared"};
> >> ```
> > 
> > Yes. This allows to paste the result back to the console.
> > This is change in behaviour but while we're not claiming
> > that th lua mode is stable I think we can do so.
> 
> Then it would be great to return it as
> 
> error “[string \"return x\"]:1: variable \'x\' is not declared"
> 
> or even better
> 
> error [[[string "return x"]:1: variable 'x' is not declared]]

This breaks the idea of having output suitable for pasting back
to the console. Take a look on yaml ouput, I made the same.

...
> 
> There is a possibility to take a length or result (select(‘#’,...))

Already fixed in v2 of the seies.