From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CD833469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  8 May 2020 19:19:14 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id g10so1846282lfj.13
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 08 May 2020 09:19:14 -0700 (PDT)
Date: Fri, 8 May 2020 19:19:10 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200508161910.GC51428@grain>
References: <20200508114714.426908-1-gorcunov@gmail.com>
 <7d39ce8a-3c12-a814-9bb3-8d43bfc6f782@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7d39ce8a-3c12-a814-9bb3-8d43bfc6f782@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/7] box/console: add support for
 internal types
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Fri, May 08, 2020 at 07:04:26PM +0300, Oleg Babin wrote:
> Hi! Thanks for patchset! I have a few comments.
> 
> I'm not sure that we should return errors in such way:
> ```
> tarantool> x
> {error = "[string \"return x\"]:1: variable \'x\' is not declared"};
> ```

Yes. This allows to paste the result back to the console.
This is change in behaviour but while we're not claiming
that th lua mode is stable I think we can do so.

> 
> Or is it expected behaviour?
> 
> Also `nil` value is ignored in some cases.
> ```
> tarantool> nil
> ;
> tarantool> nil, 2, 3
> ;
> tarantool> 1, nil, 3
> 1, nil, 3;
> ```

Thanks! I'll take a look.

> 
> And I've met strange output:
> ```
> tarantool> box.space.test.index
> {[0] = {unique = true, parts = {{type = "integer", is_nullable = "false",
> fieldno = "3"}, {type = "unsigned", is_nullable = "false", fieldno = "5"}},
> type = "TREE", id = "0", space_id = "520", name = "id"}, [1] = {unique =
> false, parts = {{type = "unsigned", is_nullable = "false", fieldno = "1"}},
> id = 1, space_id = 520, type = "TREE", name = "bucket_id"}, [bucket_id]1
>  = !!!*anchor[id]0
>  = !!!*anchor};
> ```
> 
> "!!!*anchor" looks strange. Seems it occurs when you mix map and array.

Yes, this is self reference. I need to revisit this moment. Thank you!