From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 184D2469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  8 May 2020 15:39:28 +0300 (MSK)
Date: Fri, 8 May 2020 15:39:27 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200508123927.GB2626@hpalx>
References: <20200508101703.8928-1-huston.mavr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200508101703.8928-1-huston.mavr@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] static build: set dockerfile
 entrypoint to exec form
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@gmail.com

Hi Aleksandr, thanks for the patch, LGTM.

On Fri, May 08, 2020 at 01:17:03PM +0300, HustonMmmavr wrote:
> According to dockerfile reference, there are two forms of specifying
> entrypoint: exec and shell. Exec form is preferred and allows to use
> this image in scripts.
> 
> Close #4960
> ---
> Issue: https://github.com/tarantool/tarantool/issues/4960
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-4960-inappropriate-dockerfile.staticbuild-syntax
>  Dockerfile.staticbuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index a1c47a85e..253f2d5e9 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -95,4 +95,4 @@ RUN if [ -n "${RUN_TESTS}" ]; then \
>          /usr/bin/python test-run.py --force; \
>      fi
>  
> -ENTRYPOINT /bin/bash
> +ENTRYPOINT ["/bin/bash"]
> -- 
> 2.26.2
>