From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EBC9D469710 for ; Thu, 7 May 2020 13:28:06 +0300 (MSK) Date: Thu, 7 May 2020 13:28:05 +0300 From: Sergey Ostanevich Message-ID: <20200507102805.GI112@tarantool.org> References: <20200506153843.GG112@tarantool.org> <9a29772d-0ade-5735-adc1-536d4e76a1f1@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9a29772d-0ade-5735-adc1-536d4e76a1f1@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] wal: simplify rollback List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hi! Thank you for the very detailed explanation of rollback activities between WAL and TX threads! Now it's pretty clear how you made it work. Neato! > >> > >> Also there is now a single route for commit and rollback cbus > > ^^^ move it > >> messages, called tx_complete_batch(). This change will come in > > ^^^ here > > Nope. Beforehand there was no a single route, and *now* there is a > single route. Which happened to be called tx_complete_batch(). The > accent is on *now there is a single route*. Not on *now it is called*. What I mean is actually "Also there is a single route for commit and rollback cbus messages now, called tx_complete_batch(). Sorry for misleading. LGTM. Sergos