From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E71D2469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  6 May 2020 21:04:11 +0300 (MSK)
Date: Wed, 6 May 2020 21:03:57 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200506180357.gdagxylb4oy67x7q@tkn_work_nb>
References: <1588786429.441520222@f435.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1588786429.441520222@f435.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v2] gitlab-ci: keep perf results as
	gitlab-ci artifacts`
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches <tarantool-patches@dev.tarantool.org>

LGTM.

However I would verify it on *-perf branch just in case.

WBR, Alexander Turenko.

On Wed, May 06, 2020 at 08:33:49PM +0300, Oleg Piskunov wrote:
> 
> 
> Gitlab-ci pipeline modified in order to keep
> performance results into gitlab-ci artifacts.
>  
> Closes #4920
>  
> ---
>  
> Github: https://github.com/tarantool/tarantool/tree/opiskunov/gh-4920-perf-artifacts
> Issue: https://github.com/tarantool/tarantool/issues/4920
> 
>  .gitlab-ci.yml | 5 +++++
>  1 file changed, 5 insertions(+)
>  
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index b3b07da..ae2afce 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -93,6 +93,11 @@ variables:
>    stage: perf
>    tags:
>      - docker_perf
> +  artifacts:
> +    when: always
> +    paths:
> +      - "*_result.txt"
> +      - "*_t_version.txt"
>    script:
>      - ${GITLAB_MAKE} perf_run
>  
> --
> 1.8.3.1
>