From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DEDD7469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  6 May 2020 12:08:16 +0300 (MSK)
Date: Wed, 6 May 2020 12:08:02 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200506090802.x3dro6djzqir37cy@tkn_work_nb>
References: <1587974039.618638020@f133.i.mail.ru>
 <20200430073226.GA26217@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200430073226.GA26217@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v1] Keep perf results as gitlab-ci
 artifacts
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: =?utf-8?B?0J7Qu9C10LMg0J/QuNGB0LrRg9C90L7Qsg==?= <o.piskunov@corp.mail.ru>, Oleg Piskunov <o.piskunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> Keep perf results as gitlab-ci artifacts

Nit: Let's add some prefix: I would use 'gitlab-ci'. Using of prefixes
is convenient and allows to traverse over commits faster.

> 
> Gitlab-ci pipeline modified in order to keep performance results into gitlab-ci artifacts.

Nit: Keep commit message body lines within 72 symbols.

>  
> Closes #4920
>  
> Github: https://github.com/tarantool/tarantool/tree/opiskunov/gh-4920-perf-artifacts
> Issue: https://github.com/tarantool/tarantool/issues/4920

Nit: Don't include issue no / branch into a commit message, only within
a email. Place them under '---' to distinguish from a commit message
itself.

> ---
>  .gitlab-ci.yml | 43 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index fd265aa..4b05fa5 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -201,12 +201,22 @@ perf_sysbench:
>    variables:
>      <<: *perf_vars_definition
>      BENCH: 'sysbench'
> +  artifacts:
> +    when: always
> +    paths:
> +      - Sysbench_result.txt
> +      - Sysbench_t_version.txt

I would deploy a directory with result as an artefact or use globs
(GitLab CI supports both). gitlab-ci.yml should not lean on hardcoded
bench-run paths. Can we formalize bench-run contract for performance
measurement results? Maybe, `${benchmark}_results` directory? Or
`${benchmark}_${conf}_results` if names intersection may be troublesome.

WBR, Alexander Turenko.