From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C8E04469710 for ; Tue, 5 May 2020 19:32:58 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id u15so2306212ljd.3 for ; Tue, 05 May 2020 09:32:58 -0700 (PDT) Date: Tue, 5 May 2020 19:32:54 +0300 From: Cyrill Gorcunov Message-ID: <20200505163254.GA51428@grain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/1] test: make app-tap/init_script produce less diff List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On Fri, May 01, 2020 at 08:45:25PM +0200, Vladislav Shpilevoy wrote: > When a new option is added, app-tap/init_script > outputs big diff. Because all options are printed with > ordinal indexes. Addition of a new option changes > indexes of all options after the new one. > > The patch removes indexes from the output making diff > smaller, when a new option is added. > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/app-tap/init_script-test-diff Looks ok to me. But I CC SashaT just to make sure. Reviewed-by: Cyrill Gorcunov