From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2E0784696C3 for ; Thu, 30 Apr 2020 15:16:37 +0300 (MSK) Date: Thu, 30 Apr 2020 15:16:36 +0300 From: Kirill Yukhin Message-ID: <20200430121636.rdxol2i4x2lgiiww@tarantool.org> References: <20200413193300.GA1734@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200413193300.GA1734@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] Code cleanup: sync declarations and definitions List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Hello, On 13 апр 22:33, Sergey Ostanevich wrote: > > API_EXPORT defines nothrow, so compiler warns or errors depending on the > build options in case function definition doesn't have the define. > > Synced declarations and definitions for the functions caused build > problems. > > Closes #4885 > > https://github.com/tarantool/tarantool/issues/4885 > https://github.com/tarantool/tarantool/commit/980341a53e2a5d4ba30a21adfba5b2e045dfc078 I've checked your patch into 1.10, 2.3, 2.4 and master as obvious. -- Regards, Kirill Yukhin