From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imeevma@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E21824696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 30 Apr 2020 13:32:53 +0300 (MSK)
Date: Thu, 30 Apr 2020 13:32:52 +0300
From: Mergen Imeev <imeevma@tarantool.org>
Message-ID: <20200430103251.GA4074@tarantool.org>
References: <cover.1586950754.git.imeevma@gmail.com>
 <2d865e88da427dd63acdc0e456dd7d032eee5769.1586950754.git.imeevma@gmail.com>
 <087ee40d-4a74-c44a-a47e-db480cb46a96@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <087ee40d-4a74-c44a-a47e-db480cb46a96@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 1/2] sql: fix comparison in IN
	with list of values
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sorry, I forgot about this comment. I changed the comment
in test. Diff below.

On Tue, Apr 28, 2020 at 12:53:34AM +0200, Vladislav Shpilevoy wrote:
> > diff --git a/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua
> > new file mode 100755
> > index 0000000..14ba7ad
> > --- /dev/null
> > +++ b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua
> > @@ -0,0 +1,32 @@
> > +#!/usr/bin/env tarantool
> > +test = require("sqltester")
> > +test:plan(2)
> > +
> > +--
> > +-- If left value of IN and NOT IN operators is not a vector with
> > +-- length more that one, make sure that it cannot be compared to
> 
> that -> than.

Diff

diff --git a/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua
index a03b688..5e69805 100755
--- a/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua
+++ b/test/sql-tap/gh-4692-comparison-in-IN-operator.test.lua
@@ -3,9 +3,8 @@ test = require("sqltester")
 test:plan(11)
 
 --
--- If left value of IN and NOT IN operators is not a vector with
--- length more that one, make sure that it cannot be compared to
--- right values in case they are not comparable.
+-- Make sure that the left value of IN and NOT IN operators cannot
+-- be compared to the right value in case they are not comparable.
 --
 
 test:do_catchsql_test(