From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 830164696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 30 Apr 2020 13:29:35 +0300 (MSK)
Date: Thu, 30 Apr 2020 13:29:23 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200430102923.GB12330@pony.bronevichok.ru>
References: <9c52f131fa3be0ad88085dd2398844daa89b313d.1588240080.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9c52f131fa3be0ad88085dd2398844daa89b313d.1588240080.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: fragile flaky tests from
	parallel runs
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi, Sasha

in general LGTM and see comment below.

On 12:49 Thu 30 Apr , Alexander V. Tikhonov wrote:
> Fragiled flaky tests from parallel runs to avoid
> of flaky fails in regular testing:

"fragiled flaky test" is a something like "butter oil"?
I propose make commit message more clear. For example:
"Mark tests as fragile in a test's configs"

>   snapshot.test.py            ; gh-4514
>   init_storage.test.py        ; gh-4949
>   stat.test.lua               ; gh-4951
>   xlog/checkpoint_daemon.test.lua ; gh-4952
> 
> Part of #4953
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/fragile-flaky-tests
> Issue: https://github.com/tarantool/tarantool/issues/4953
> 
>  test/box-py/suite.ini         | 1 +
>  test/replication-py/suite.ini | 1 +
>  test/vinyl/suite.ini          | 1 +
>  test/xlog/suite.ini           | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/test/box-py/suite.ini b/test/box-py/suite.ini
> index 18737e48f..d1ff0fbfd 100644
> --- a/test/box-py/suite.ini
> +++ b/test/box-py/suite.ini
> @@ -5,3 +5,4 @@ script = box.lua
>  lua_libs = lua/fiber.lua lua/fifo.lua
>  use_unix_sockets = True
>  is_parallel = True
> +fragile = snapshot.test.py            ; gh-4514
> diff --git a/test/replication-py/suite.ini b/test/replication-py/suite.ini
> index df2dd8ef0..2658f4816 100644
> --- a/test/replication-py/suite.ini
> +++ b/test/replication-py/suite.ini
> @@ -3,3 +3,4 @@ core = tarantool
>  script =  master.lua
>  description = tarantool/box, replication
>  is_parallel = True
> +fragile = init_storage.test.py        ; gh-4949
> diff --git a/test/vinyl/suite.ini b/test/vinyl/suite.ini
> index c8bc270f3..44c53dc68 100644
> --- a/test/vinyl/suite.ini
> +++ b/test/vinyl/suite.ini
> @@ -15,3 +15,4 @@ pretest_clean = True
>  fragile = errinj.test.lua             ; gh-4346
>            select_consistency.test.lua ; gh-4385
>            throttle.test.lua           ; gh-4168
> +          stat.test.lua               ; gh-4951
> diff --git a/test/xlog/suite.ini b/test/xlog/suite.ini
> index 635ec53c1..8e4c4d374 100644
> --- a/test/xlog/suite.ini
> +++ b/test/xlog/suite.ini
> @@ -10,3 +10,4 @@ use_unix_sockets_iproto = True
>  long_run = snap_io_rate.test.lua
>  is_parallel = True
>  pretest_clean = True
> +fragile = xlog/checkpoint_daemon.test.lua ; gh-4952
> -- 
> 2.17.1
> 

-- 
sergeyb@