From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 79CE74696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 30 Apr 2020 12:50:12 +0300 (MSK)
Date: Thu, 30 Apr 2020 12:50:00 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200430095000.GA12330@pony.bronevichok.ru>
References: <1587472755.685972468@f558.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1587472755.685972468@f558.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH v1] bench-run: refactoring perf
	docker image
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: =?utf-8?B?0J7Qu9C10LMg0J/QuNGB0LrRg9C90L7Qsg==?= <o.piskunov@corp.mail.ru>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi, Oleg

LGTM

On 15:39 Tue 21 Apr , Олег Пискунов wrote:
> 
> 
> Fix docker image for perf testing:
> - Disable caching for second stage docker file creation
>   for correct Tarantool and bench-run version checkout.
> - bench-run repository creation moved from dockerfile
>   of the first stage to the second.
>  
> Close #4870
> ---
>  
> Github: https://github.com/tarantool/bench-run/tree/opiskunov/gh-4870-refactor-docker-perf
> Issue: https://github.com/tarantool/tarantool/issues/4870
>  
>  dockerfiles/ubuntu_benchs | 3 ---
>  dockerfiles/ubuntu_tnt    | 3 +++
>  targets.mk                | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>  
> diff --git a/dockerfiles/ubuntu_benchs b/dockerfiles/ubuntu_benchs
> index fd9acb4..f5389f4 100644
> --- a/dockerfiles/ubuntu_benchs
> +++ b/dockerfiles/ubuntu_benchs
> @@ -70,6 +70,3 @@ WORKDIR /opt/linkbench
>  RUN luarocks install \
>      https://raw.githubusercontent.com/tarantool/gperftools/master/rockspecs/gperftools-scm-1.rockspec \
>      --local >build.log 2>&1 || ( cat build.log && false )
> -
> -# benchmarks runners
> -RUN git clone https://github.com/tarantool/bench-run.git /opt/bench-run
> diff --git a/dockerfiles/ubuntu_tnt b/dockerfiles/ubuntu_tnt
> index 361e9d6..1704508 100644
> --- a/dockerfiles/ubuntu_tnt
> +++ b/dockerfiles/ubuntu_tnt
> @@ -8,6 +8,9 @@ RUN ( cmake . -DENABLE_DIST=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo >build.log 2>&1
>      && make -j >>build.log 2>&1 && make install >>build.log 2>&1 ) || \
>      ( cat build.log && false )
>  
> +# benchmarks runners
> +RUN git clone https://github.com/tarantool/bench-run.git /opt/bench-run
> +
>  # cbench
>  RUN git clone https://github.com/tarantool/cbench.git /opt/cbench
>  WORKDIR /opt/cbench
> diff --git a/targets.mk b/targets.mk
> index 6cf36b6..581b722 100644
> --- a/targets.mk
> +++ b/targets.mk
> @@ -21,7 +21,7 @@ prepare:
>         docker push ${IMAGE_PERF}
>         # build Tarantool and benchmarks with depends on Tarantool sources
>         ${DOCKERFILE_BUILD} --build-arg image_from=${IMAGE_PERF} \
> -               -t ${IMAGE_PERF_BUILT} -f bench-run/dockerfiles/ubuntu_tnt .
> +               -t ${IMAGE_PERF_BUILT} --no-cache -f bench-run/dockerfiles/ubuntu_tnt .
>         docker push ${IMAGE_PERF_BUILT}
>  
>  # #####################################################
> --
> 1.8.3.1
>  

-- 
sergeyb@