From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A62F34696C3 for ; Mon, 27 Apr 2020 20:16:44 +0300 (MSK) Date: Mon, 27 Apr 2020 20:09:36 +0300 From: Igor Munkin Message-ID: <20200427170936.GO11314@tarantool.org> References: <20200316121548.48251-1-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200316121548.48251-1-arkholga@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by default List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org Olya, Thanks for the patch! Unfortunately, the changes don't fix the problem[1]. Did you find the approach provided by Sasha[2] wrong? On 16.03.20, Olga Arkhangelskaia wrote: > Remove setting old CMP0037 policy explicitly, it may be > removed in later versions of cmake. > > Closes #3587 > --- > Branches: https://github.com/tarantool/tarantool/tree/OKriw/gh-3587-CMP0037-OLD-cmake-deprecation-warning-full-ci > > test/CMakeLists.txt | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt > index 9b5df7dc5..61bf7d5e1 100644 > --- a/test/CMakeLists.txt > +++ b/test/CMakeLists.txt > @@ -17,10 +17,6 @@ endfunction() > add_compile_flags("C;CXX" > "-Wno-unused-parameter") > > -if(POLICY CMP0037) > - cmake_policy(SET CMP0037 OLD) > -endif(POLICY CMP0037) > - > add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/luajit-tap > COMMAND ${CMAKE_COMMAND} -E create_symlink > ${PROJECT_SOURCE_DIR}/third_party/luajit/test > -- > 2.20.1 (Apple Git-117) > [1]: https://gitlab.com/tarantool/tarantool/-/jobs/472976392#L464 [2]: https://github.com/tarantool/tarantool/issues/3587#issue-346204529 -- Best regards, IM