From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AF72A4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 27 Apr 2020 18:37:26 +0300 (MSK)
Date: Mon, 27 Apr 2020 15:37:25 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200427153725.GG30870@tarantool.org>
References: <d0cf930d7a2dcbeb5e0abac0fd19f524b037e1d5.1585665298.git.korablev@tarantool.org>
 <3f1e18cc-cc18-b586-825b-3e4e3a9c8e3f@tarantool.org>
 <20200427121701.GA30870@tarantool.org>
 <20200427123936.GA24638@atlas>
 <20200427151854.GE30870@tarantool.org>
 <20200427152055.GA2279@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200427152055.GA2279@atlas>
Subject: Re: [Tarantool-patches] [PATCH] vinyl: unthrottle scheduler on
	checkpoint
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

On 27 Apr 18:20, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/04/27 18:20]:
> > > > Checkpoint daemon uses directly box.snapshot(), so now we can't tell
> > > > whether checkpoint is launched manually or automatically. To differ
> > > > these scenarious we can make checkpoint daemon call sort of
> > > > box.__scheduled_snapshot() (which won't be part of public API ofc).
> > > > Then we will be able to pass boolean parameter to begin_checkpoint()
> > > > indicating manual/auto mode. Or simply close issue as wont fix :)
> > > 
> > > Uhm, no, checkpoint daemon uses gc_do_checkpoint() and it doesn't
> > > use box.snapshot().
> > 
> > Seems we are looking at different branches: 1.10 still uses checkpoint
> > daemon written in Lua. If this patch should be pushed to master branch
> > only, then I guess it would be easy to patch engine_begin_checkpoint()
> > and make it accept argument responsible for checkpoint mode (scheduled
> > or manual).
> 
> Why do you need to fix 1.10?

For instance, it would make test backporting process easier.
Otherwise we will get different behaviours while using
ERRINJ_VY_SCHED_TIMEOUT error injection.
 
> -- 
> Konstantin Osipov, Moscow, Russia
> https://scylladb.com