From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 557FB4696C3 for ; Mon, 27 Apr 2020 18:18:55 +0300 (MSK) Date: Mon, 27 Apr 2020 15:18:54 +0000 From: Nikita Pettik Message-ID: <20200427151854.GE30870@tarantool.org> References: <3f1e18cc-cc18-b586-825b-3e4e3a9c8e3f@tarantool.org> <20200427121701.GA30870@tarantool.org> <20200427123936.GA24638@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200427123936.GA24638@atlas> Subject: Re: [Tarantool-patches] [PATCH] vinyl: unthrottle scheduler on checkpoint List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org On 27 Apr 15:39, Konstantin Osipov wrote: > * Nikita Pettik [20/04/27 15:19]: > > Checkpoint daemon uses directly box.snapshot(), so now we can't tell > > whether checkpoint is launched manually or automatically. To differ > > these scenarious we can make checkpoint daemon call sort of > > box.__scheduled_snapshot() (which won't be part of public API ofc). > > Then we will be able to pass boolean parameter to begin_checkpoint() > > indicating manual/auto mode. Or simply close issue as wont fix :) > > Uhm, no, checkpoint daemon uses gc_do_checkpoint() and it doesn't > use box.snapshot(). Seems we are looking at different branches: 1.10 still uses checkpoint daemon written in Lua. If this patch should be pushed to master branch only, then I guess it would be easy to patch engine_begin_checkpoint() and make it accept argument responsible for checkpoint mode (scheduled or manual). > > -- > Konstantin Osipov, Moscow, Russia