From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C70644696C3 for ; Mon, 27 Apr 2020 15:39:38 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id a21so14500061ljj.11 for ; Mon, 27 Apr 2020 05:39:38 -0700 (PDT) Date: Mon, 27 Apr 2020 15:39:36 +0300 From: Konstantin Osipov Message-ID: <20200427123936.GA24638@atlas> References: <3f1e18cc-cc18-b586-825b-3e4e3a9c8e3f@tarantool.org> <20200427121701.GA30870@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427121701.GA30870@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vinyl: unthrottle scheduler on checkpoint List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Nikita Pettik [20/04/27 15:19]: > Checkpoint daemon uses directly box.snapshot(), so now we can't tell > whether checkpoint is launched manually or automatically. To differ > these scenarious we can make checkpoint daemon call sort of > box.__scheduled_snapshot() (which won't be part of public API ofc). > Then we will be able to pass boolean parameter to begin_checkpoint() > indicating manual/auto mode. Or simply close issue as wont fix :) Uhm, no, checkpoint daemon uses gc_do_checkpoint() and it doesn't use box.snapshot(). -- Konstantin Osipov, Moscow, Russia