From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 23F354696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Apr 2020 13:23:23 +0300 (MSK)
Date: Fri, 24 Apr 2020 13:16:14 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200424101614.GG11314@tarantool.org>
References: <cover.1587476678.git.sergeyb@tarantool.org>
 <c507f3d3ffc573e10739929fab4fd3419b56e51f.1587476678.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c507f3d3ffc573e10739929fab4fd3419b56e51f.1587476678.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 9/10] Disabled test/luajit-tap in
	luacheckrc
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Sergey,

Thanks for the patch, but it looks irrelevant. Just apply the last patch
in the series, bump luajit submodule before applying all other patches
and suppress jit global variable. I guess this patch can be discarded.

On 21.04.20, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> temporarily disabled luajit-tap tests while patch with fixes not applied
> ---
>  .luacheckrc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.luacheckrc b/.luacheckrc
> index cec1f4ffe..b8ee14b50 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -19,6 +19,7 @@ exclude_files = {
>      "test/xlog/*.lua",
>      "test/wal_off/*.lua",
>      "test/var/**/*.lua",
> +    "test/luajit-tap",
>      "test-run/**/*.lua",
>      "third_party/**/*.lua",
>      ".rocks/**/*.lua",
> -- 
> 2.23.0
> 

-- 
Best regards,
IM