From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CE8EA4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Apr 2020 10:57:15 +0300 (MSK)
Date: Fri, 24 Apr 2020 10:57:15 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200424075714.g4tosz6q57r6jazl@tarantool.org>
References: <20200422195658.14170-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200422195658.14170-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] cbus: fix inconsistency in endpoint
	creation
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

On 22 апр 22:56, Cyrill Gorcunov wrote:
> The notification of wait variable shall be done under
> a bound mutex locked. Otherwise the results are not
> guaranteed (see pthread manuals).
> 
> Thus when we create a new endpoint via cbus_endpoint_create
> and there is an other thread which sleeps inside cpipe_create
> we should notify the sleeper under cbus.mutex.
> 
> Fixes #4806
> 
> Reported-by: Alexander Turenko <alexander.turenko@tarantool.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

LGTM.

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin