From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EC14D4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Apr 2020 02:36:32 +0300 (MSK)
Date: Fri, 24 Apr 2020 02:29:24 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200423232924.GF11314@tarantool.org>
References: <cover.1587476678.git.sergeyb@tarantool.org>
 <0b86996f4cac3e620137abf271a43bde499e5334.1587476678.git.sergeyb@tarantool.org>
 <20200423232446.GD11314@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200423232446.GD11314@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 7/10] schema: fix index promotion
	to functional index
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

I don't know whether this patch needs a ChangeLog entry, but it's
missing here.

On 24.04.20, Igor Munkin wrote:
> Vlad,
> 
> Thanks for the patch! I'm glad we found and fixedseveral bugs as a
> result of luacheck activity. LGTM (I guess this patch can be also pushed
> out of order along with the following one).
> 
> On 21.04.20, sergeyb@tarantool.org wrote:
> > From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > 
> > When index:alter() was called on a non-functional index with
> > specified 'func', it led to accessing a not declared variable in
> > schema.lua.
> > ---
> >  src/box/lua/schema.lua          |  2 +-
> >  test/engine/func_index.result   | 36 +++++++++++++++++++++++++++++++++
> >  test/engine/func_index.test.lua | 14 +++++++++++++
> >  3 files changed, 51 insertions(+), 1 deletion(-)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM