From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D9EA94696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 24 Apr 2020 02:34:46 +0300 (MSK)
Date: Fri, 24 Apr 2020 02:27:38 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200423232738.GE11314@tarantool.org>
References: <cover.1587476678.git.sergeyb@tarantool.org>
 <a82d9b282e5db48e870221d0316823898afcd33b.1587476678.git.sergeyb@tarantool.org>
 <20200421195231.GE8314@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200421195231.GE8314@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 8/10] schema: fix internal
	symbols dangling in _G
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

I don't know whether this patch needs a ChangeLog entry, but it's
missing here.

On 21.04.20, Igor Munkin wrote:
> Vlad,
> 
> Thanks for the patch! LGTM (feel free to push out of order as obvious).
> 
> Side note: I don't know whether we need a test for it (a simple lookup
> for <update_format> and <role_check_grant_revoke_of_sys_priv> in _G) but
> on the second thought it looks excess and out of the common practice.
> 
> On 21.04.20, sergeyb@tarantool.org wrote:
> > From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> > 
> > A couple of functions were mistakenly declared as 'function'
> > instead of 'local function' in schema.lua. That led to their
> > presence in the global namespace.
> > ---
> >  src/box/lua/schema.lua | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.23.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM