From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5A5CD4696C3 for ; Thu, 23 Apr 2020 17:06:06 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id 131so4826671lfh.11 for ; Thu, 23 Apr 2020 07:06:06 -0700 (PDT) Date: Thu, 23 Apr 2020 17:06:04 +0300 From: Konstantin Osipov Message-ID: <20200423140604.GB19129@atlas> References: <20200423130154.23910-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200423130154.23910-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] replication: list anonymous replicas in box.info.replication List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Serge Petrenko [20/04/23 16:05]: > A new field is added to replica info in `box.info.replication` output: > `anon`. The field is boolean and set to `true` for anonymous replicas > and to `false` for normal replicas. > > Also now anonymous replicas are listed in `box.info.replication` > together with normal ones, so it's easier to track their connection > state. Anonymous replicas occupy table slots past the biggest-id normal > replica. Example: > ``` > ... > replication: > 1: > id: 1 > uuid: 326eb713-1b79-4b43-9b48-661314260c61 > lsn: 4 > anon: false > 2: ^^^^^^^ This is not an ordinal number, it's server id. An anonymous replica doesn't have server id. Why do you think assigning an unused id is a good idea? This will break monitoring which may rely on server id being stable. -- Konstantin Osipov, Moscow, Russia