From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A9C804696C3 for ; Thu, 23 Apr 2020 13:30:27 +0300 (MSK) Date: Thu, 23 Apr 2020 13:30:23 +0300 From: Sergey Bronnikov Message-ID: <20200423103023.GB84748@pony.bronevichok.ru> References: <20200421140258.42949-1-sergeyb@tarantool.org> <20200423062439.GA57047@pony.bronevichok.ru> <20200423100334.GG8314@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200423100334.GG8314@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On 13:03 Thu 23 Apr , Igor Munkin wrote: > Sergey, > > Thank you for the changes! Sorry for nitpicking, but I still have > several comments regarding commit message: > > | test: fix warnings spotted by luacheck > | > | luacheck is integrated in tarantool CI pipeline and respect .luacheckrc in > > Typo: s/respect/respects/. Updated in a branch. > | tarantool repo, so jit global is suppressed there. > | > | Reviewed-by: Igor Munkin > | Co-authored-by: Igor Munkin > > Minor: I failed to find strict rules about the ordering misc-by tags, > but here[1] I follows the kernel example[2] where Co-developed-by tag > (or Co-authored-by alternative) goes prior to Reviewed-by one. I guess > it would be nice to use a single sort order for the tags. But again, I > find no rule and tag practice is even optional (it's not mentioned in > our contributors guide), so feel free to ignore this comment. Perhaps it make sense. Updated in a branch.