From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1C5DE4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 23 Apr 2020 13:10:42 +0300 (MSK)
Date: Thu, 23 Apr 2020 13:03:34 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200423100334.GG8314@tarantool.org>
References: <cover.1587476678.git.sergeyb@tarantool.org>
 <20200421140258.42949-1-sergeyb@tarantool.org>
 <20200423062439.GA57047@pony.bronevichok.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200423062439.GA57047@pony.bronevichok.ru>
Subject: Re: [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings
	spotted by luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Sergey,

Thank you for the changes! Sorry for nitpicking, but I still have
several comments regarding commit message:

| test: fix warnings spotted by luacheck
|
| luacheck is integrated in tarantool CI pipeline and respect .luacheckrc in

Typo: s/respect/respects/.

| tarantool repo, so jit global is suppressed there.
|
| Reviewed-by: Igor Munkin <imun@tarantool.org>
| Co-authored-by: Igor Munkin <imun@tarantool.org>

Minor: I failed to find strict rules about the ordering misc-by tags,
but here[1] I follows the kernel example[2] where Co-developed-by tag
(or Co-authored-by alternative) goes prior to Reviewed-by one. I guess
it would be nice to use a single sort order for the tags. But again, I
find no rule and tag practice is even optional (it's not mentioned in
our contributors guide), so feel free to ignore this comment.

|

Otherwise, LGTM, thanks!

On 23.04.20, Sergey Bronnikov wrote:
> GH branch:
> https://github.com/tarantool/luajit/tree/ligurio/gh-4681-fix-luacheck-warnings
> 
> On 17:00 Tue 21 Apr , sergeyb@tarantool.org wrote:
> > From: Sergey Bronnikov <sergeyb@tarantool.org>

[1]: https://github.com/tarantool/luajit/commit/4f4fd9e
[2]: https://github.com/torvalds/linux/commit/56df70a

-- 
Best regards,
IM