From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 966E44696C3 for ; Wed, 22 Apr 2020 13:14:31 +0300 (MSK) Date: Wed, 22 Apr 2020 13:14:29 +0300 From: Sergey Bronnikov Message-ID: <20200422101429.GA2692@pony.bronevichok.ru> References: <20200421140258.42949-1-sergeyb@tarantool.org> <20200421193301.GD8314@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200421193301.GD8314@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 22:33 Tue 21 Apr , Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please adjust the commit subject considering our > contributors guide[1]. Since the commit is for tarantool/luajit repo I > propose the following: > | test: fix warnings spotted by luacheck Updated on the branch. > Also, It would be nice to mention in commit message that luacheck is > integrated in tarantool CI pipeline that respect .luacheckrc in > tarantool repo (since jit global is suppressed there). > > Furthermore I applied your patch and as a result of manual luacheck run > in test directory I faced the following warnings: Applied on the branch, thanks! Sergey