From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 979654696C3 for ; Tue, 21 Apr 2020 17:45:25 +0300 (MSK) Date: Tue, 21 Apr 2020 17:45:24 +0300 From: Sergey Bronnikov Message-ID: <20200421144524.GA81956@pony.bronevichok.ru> References: <19afcf4e-9341-b13d-c14a-7ddd916b1874@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <19afcf4e-9341-b13d-c14a-7ddd916b1874@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Oleg Babin Cc: tarantool-patches@dev.tarantool.org Hi! On 17:13 Tue 21 Apr , Oleg Babin wrote: > Hi! Thanks for the patch. It closes this issue - > https://github.com/tarantool/tarantool/issues/4812 > > I think you could add it to commit message. Oleg, updated commit message in the branch. Thanks! > On 21/04/2020 17:00, sergeyb@tarantool.org wrote: > > From: Vladislav Shpilevoy > > > > A couple of functions were mistakenly declared as 'function' > > instead of 'local function' in schema.lua. That led to their > > presence in the global namespace.