From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B7D074696C3 for ; Mon, 20 Apr 2020 22:29:21 +0300 (MSK) Received: by mail-lf1-f66.google.com with SMTP id j14so9007747lfg.9 for ; Mon, 20 Apr 2020 12:29:21 -0700 (PDT) Date: Mon, 20 Apr 2020 22:29:19 +0300 From: Cyrill Gorcunov Message-ID: <20200420192919.GZ3072@uranus> References: <20200420131115.42047-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420131115.42047-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary errors on replicating from an anonymous instance List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On Mon, Apr 20, 2020 at 04:11:15PM +0300, Serge Petrenko wrote: > Since the anonymous replica implementation, it was forbidden to > replicate (join/subscribe/register) from anonymous instances. > Actually, only joining and register should be banned. Anonymous replica > isn't able to register its peer in _cluster anyway. > Allow subscribing to anonymous instances and remove all the errors > mentioning unsupported replication from anonymous replica. Join and > register are covered by ER_READONLY errors, since anonymous replicas > must be read-only. > > Closes #4696 > --- I don't see any obvious errors here. Still I'm far from being repication expert. So I can put Reviewed-by: Cyrill Gorcunov only.