From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 092A34696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 20 Apr 2020 17:22:38 +0300 (MSK)
Date: Mon, 20 Apr 2020 17:22:37 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200420142237.jrnslig6pusym6nd@tarantool.org>
References: <cover.1587154034.git.korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1587154034.git.korablev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Stacked diagnostic area
 follow-ups
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hello,

On 17 апр 23:16, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-4887-ref-error-on-prev
> Issue: https://github.com/tarantool/tarantool/issues/4887
> 
> Changes in v2:
> 
>  - modified test so that now it uses weak references to check that
> gc collected error objects (i.e. there's no memory leaks);
>  - added overflow check in error_ref() so that after 2^32 calls
> of box.error.last() or error:prev() error object won't contain
> broken reference counter.
> 
> Nikita Pettik (2):
>   box/error: don't allow overflow of error ref counter
>   box/error: ref error.prev while accessing it

I've checked your patchset into master.

However, looks like it'd be better to just replace int32 to
int64 and avoid problems if GC64.

Since I've already checked the patch in, could you please
prepare a patch which will revert functional changes of 2/2
and use int64 instead?

--
Regards, Kirill Yukhin