From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 567004696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 20 Apr 2020 15:04:50 +0300 (MSK)
Date: Mon, 20 Apr 2020 14:57:42 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200420115742.GY8314@tarantool.org>
References: <cover.1587172237.git.alexander.turenko@tarantool.org>
 <ac2449a59ea0514def8da18390cc599ffeb76ff6.1587172237.git.alexander.turenko@tarantool.org>
 <20200420005740.GV8314@tarantool.org>
 <20200420063840.azqawj2qep7ozpv4@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200420063840.azqawj2qep7ozpv4@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH 2/2] popen: add popen Lua module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

On 20.04.20, Alexander Turenko wrote:
> Thank you, Igor!
> 
> I made simple changes and postponed ones where I need a bit more time.
> Hope, you don't mind.

Totally OK with it.

> 
> Marked postponed questions as (postponed) in the email.
> 
> My answers are below.
> 
> WBR, Alexande Turenko.
> 

<snipped>

> 
> > > +static int
> > > +luaT_push_string_noxc(struct lua_State *L, char *str, size_t len)
> > > +{
> > > +	lua_pushcfunction(L, luaT_push_string_noxc_wrapper);
> > > +	lua_pushlightuserdata(L, str);
> > > +	lua_pushinteger(L, len);
> > > +	return luaT_call(L, 2, 1);
> > > +}
> > 
> > Minor: IMHO luaT_pushstring_* is more Lua-like naming.
> 
> It is from past agreements too: we discussed this with Vladimir D. and
> agreed to split 'foo' and 'bar' in 'lua*_foo_bar_baz()', when there is
> 'baz'. When there is no 'baz', it is 'lua*_foobar()'.

Are there any docs/guides/notes as a result of this discussion?

> 

<snipped>

> 
> > > +
> > > +		lua_getfield(L, 2, "timeout");
> > > +		if (!lua_isnil(L, -1) &&
> > > +		    (timeout = luaT_check_timeout(L, -1)) < 0.0)
> > > +			goto usage;
> > > +		lua_pop(L, 1);
> > 
> > Minor: I see this passage only in two similar places, so I propose to
> > move everything to a timeout-related helper.
> 
> luaT_check_timeout() is already this helper. Don't sure it worth to add
> one more wrapping level.

I mean you can also move there all table manipulations and checks.

> 

<snipped>

-- 
Best regards,
IM