From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 63F884696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 20 Apr 2020 11:05:48 +0300 (MSK)
Date: Mon, 20 Apr 2020 11:05:47 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200420080547.x5tttvnqcmplksp6@tarantool.org>
References: <cover.1587334824.git.lvasiliev@tarantool.org>
 <6d673bc4-c85b-219e-6ff4-79efc7627275@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6d673bc4-c85b-219e-6ff4-79efc7627275@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH V6 00/10] Extending error
	functionality
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 20 апр 02:26, Vladislav Shpilevoy wrote:
> Hi!
> 
> In short: formally LGTM.
> 
> Long version:
> 
> I don't like doing and reviewing patches in such a hurry.
> This feature clearly lacked planning, design, and discussion
> with community, RFC for the final version before its
> implementation.

That is true. Size of the feature was underestimated.

> It is still unfinished because of underdesigned traceback
> feature, because of payload absence. IMO, MP_EXT is also an
> overkill. Tuples live fine as MP_ARRAY, and they are the most
> used type. We should have gone for simple MP_MAP, without
> MP_EXT. Just a map.

We already broken connectors by introducing UUID (w/ MP_EXT).

> It is worth mentioning separately, how hard it is to use the
> error marshaling now, because of this session setting. And
> there still is no way to enable the feature without touching
> the session, even if all my connectors support it. As I
> mentioned, enabling it for every session manually is a
> non-trivial task for a user.

I guess we can switch it on by default in future releases.

> But we have releases coming, so lets push all in whatever
> state it is, of course.

--
Regards, Kirill Yukhin