From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0B4194696C3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 20 Apr 2020 10:59:09 +0300 (MSK)
Date: Mon, 20 Apr 2020 10:59:09 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200420075908.rdgv4bnatu4hp3q2@tarantool.org>
References: <1581360313.873049294@f221.i.mail.ru>
 <20200215175046.GE19902@atlas>
 <20200215201903.z6b7v33mo5ea7k4c@tkn_work_nb>
 <20200217074052.GA15384@atlas>
 <20200420063050.twyrcveukpfwt7cu@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200420063050.twyrcveukpfwt7cu@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did
 not work on mac
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hello,

On 20 апр 09:30, Alexander Turenko wrote:
> On Mon, Feb 17, 2020 at 10:40:52AM +0300, Konstantin Osipov wrote:
> > * Alexander Turenko <alexander.turenko@tarantool.org> [20/02/15 23:22]:
> > > > Is it fixed in the upstream? Why is noone complaining in the
> > > > upstream? Is there a bug in the upstream?
> > > 
> > > Let me read changelog for you:
> > 
> > Well, I guess the commit comment should say that this is only an
> > update from the upstream.
> > 
> > Let me read third_party/README for you!
> > 
> > How to update libev
> > ===================
> > 
> > Remove Tarantool patches (see csv diff -U8).
> > cvs up
> > Add patches back.
> > 
> > Did the patch follow the procedure? If it did, it should clearly
> > state that it updated libev, and to which version.
> 
> This have sense.
> 
> But I would include the backport of the fix in the upcoming release.
> 
> Pushed to Totktonada/gh-3867-fix-select-on-mac-os-full-ci and shown
> below.

I've checked your patch into 1.10, 2.2, 2.3 and master.

--
Regards, Kirill Yukhin