From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5D4824696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 19 Apr 2020 19:23:32 +0300 (MSK)
Date: Sun, 19 Apr 2020 19:23:27 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200419162327.6hwg7xm4l75izzur@tkn_work_nb>
References: <65798b71932c21183072decd2cce8b2b0f88b884.1585773275.git.alexander.turenko@tarantool.org>
 <78056845-c72f-f97e-de62-2f04baaed0e0@tarantool.org>
 <20200403233859.57lre4ef6co22g3e@tkn_work_nb>
 <61a72f34-7bd0-576e-e305-dfee085ca724@tarantool.org>
 <20200405120544.sktsaxfczlkz4ehq@tkn_work_nb.domru>
 <26b560a7-886b-30e9-58aa-fb4f3b26e559@tarantool.org>
 <20200406113935.fu3zli6s5x4dusgb@tkn_work_nb>
 <26e71870-33fa-9ec2-2493-d565dbc9d0e7@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <26e71870-33fa-9ec2-2493-d565dbc9d0e7@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] net.box: fix fetching of schema of
 an old version
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> > It seems logical to move snapshots out from test suites, since they will
> > be used across the test suites. What do you think?
> 
> It is not always the case. A snapshot is ok to use across tests only if
> it is not related to any particular test more than to others. Only empty
> snapshots satisfy that criteria. The reason is that we are obligated to
> keep tests isolated from each other. And if you use one non-empty snapshot
> for multiple tests, the policy will be violated.

(Continued snap/upgrade discussion in the sibling email thread.)

How about this directory structure?

 test/
 |
 +- snap/
    |
    +- how_to_add_new_test.md
    |
    +- xlog/
    |  |
    |  +- gh-4771-upgrade-sequence/
    |     |
    |     +- fill.lua
    |     +- 2.1.3/
    |        |
    |        +- *.snap
    |
    +- box-tap/
       |
       +- gh-4691-net-box-connect-schema-2-1-3/
          |
          +- fill.lua
          +- 2.1.3/
             |
             +- *.snap

Key points:

* All snapshots are in one place: it is easier to keep them right
  structured.
* Snapshots are organized on per-test basis.

Alternative:

 test/
 |
 +- xlog/
 |  |
 |  +- snap/
 |     |
 |     +- how_to_add_new_test.md
 |     |
 |     +- gh-4771-upgrade-sequence/
 |        |
 |        +- fill.lua
 |        +- 2.1.3/
 |           |
 |           +- *.snap
 |
 +- box-tap/
    |
    +- snap/
       |
       +- how_to_add_new_test.md -> ../../xlog/snap/how_to_add_new_test.md
       |
       +- gh-4691-net-box-connect-schema-2-1-3/
          |
          +- fill.lua
          +- 2.1.3/
             |
             +- *.snap

Key points:

* All snapshots organized as same structured subtrees.
* Same as above, snapshots are organized on per-test basis.

WBR, Alexander Turenko.