From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 23B024696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 22:51:47 +0300 (MSK)
Date: Fri, 17 Apr 2020 22:51:46 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200417195146.GE115@pony.bronevichok.ru>
References: <cover.1586849129.git.sergeyb@tarantool.org>
 <37835c4eb52f9ac21b6e7347a19cf5ded543b3c9.1586849129.git.sergeyb@tarantool.org>
 <ab91fb26-cb53-cfa9-e2fc-4d02bcb01cf4@tarantool.org>
 <20200417120531.GM8314@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200417120531.GM8314@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/6] Fix luacheck warnings in test/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Igor,

On 15:05 Fri 17 Apr , Igor Munkin wrote:

<snipped>

> > diff --git a/test/app-tap/tarantoolctl.test.lua b/test/app-tap/tarantoolctl.test.lua
> > index 4d7059559..3fda53274 100755
> > --- a/test/app-tap/tarantoolctl.test.lua
> > +++ b/test/app-tap/tarantoolctl.test.lua
> > @@ -97,23 +97,14 @@ local function tctl_wait_start(dir, name)
> >              fiber.sleep(0.01)
> >          end
> >          ::again::
> > -        while true do
> > -            local stat, nb = pcall(require('net.box').new, path, {
> > -                wait_connected = true, console = true
> > -            })
> > -            if stat == false then
> > -                fiber.sleep(0.01)
> > -                goto again
> > -            else
> > -                break
> > -            end
> > -            local stat, msg = pcall(nb.eval, nb, 'require("fiber").time()')
> > -            if stat == false then
> > -                fiber.sleep(0.01)
> > -            else
> > -                break
> > -            end
> > +        local stat, nb = pcall(require('net.box').new, path, {
> 
> I guess you can drop nb here, since it's unused.

'nb' variable has been removed and patch updated, thanks!

<snipped>