From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4C2BC4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 15:20:50 +0300 (MSK)
Date: Fri, 17 Apr 2020 15:13:43 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200417121343.GN8314@tarantool.org>
References: <cover.1586849129.git.sergeyb@tarantool.org>
 <56290abaaa1850a223eac0fa7165bcb9f890501d.1586849129.git.sergeyb@tarantool.org>
 <20200415205102.GF8314@tarantool.org>
 <20200417092655.GC115@pony.bronevichok.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200417092655.GC115@pony.bronevichok.ru>
Subject: Re: [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in
	src/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

Sergey,

On 17.04.20, Sergey Bronnikov wrote:
> Igor, thanks for review!
> See my answers below.
> 
> On 23:51 Wed 15 Apr , Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch!
> > 

<snipped>

> > I see no reasons to leave other W212[unused argument self] occurences.
> > Here is a diff:
> 
> Vladislav already told me in previous review iterations that '_' is less
> readable than 'self', so it was a reason why haven't fixed them. I have
> found a way to supress only W212 related to 'self' and applied it in
> branch.

Nice! That's exactly what we need for this issue!

> 
> S.

-- 
Best regards,
IM