From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 798BF4696C3 for ; Fri, 17 Apr 2020 15:03:56 +0300 (MSK) Date: Fri, 17 Apr 2020 14:56:49 +0300 From: Igor Munkin Message-ID: <20200417115649.GL8314@tarantool.org> References: <20200324085243.29337-1-arkholga@tarantool.org> <20200414125207.GK5713@tarantool.org> <67f56383-7f34-853b-39b7-f4e04dfed595@tarantool.org> <20200416211508.GJ8314@tarantool.org> <38a51d9d-eebf-3ea4-89cd-46717fd9fb75@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <38a51d9d-eebf-3ea4-89cd-46717fd9fb75@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] say: fix syslog format List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org Olya, Thanks, LGTM now. Side note: I shared the recipe about diff pasting via vim[1] and hope it is helpful. On 17.04.20, Olga Arkhangelskaia wrote: > Igor, thanks a lot for your patience. > > I have fixed all nits you have mentioned. > > See diff below! > >  12  src/lib/core/say.c                   | 14 ++++++++-- >  13  test/box-tap/gh-4785-syslog.test.lua | 42 > ++++++++++++++++++++++++++++ >  14  2 files changed, 54 insertions(+), 2 deletions(-) >  15  create mode 100755 test/box-tap/gh-4785-syslog.test.lua >  - >  26 +`....../* >  27 +`...... * When logger type is SAY_LOGGER_BOOT it simply prints >  28 +`...... * every message to stdout intact and can't be formatted. >  29 +`...... * SAY_LOGGER_SYSLOG type uses the well-documented and >  30 +`...... * *recommended* format described in the RFC below: >  31 +`...... * https://tools.ietf.org/html/rfc3164#section-4.1 >  32 +`...... * Thereby format can't be changed for this type either. >  33 +`...... */ >  34 +`......bool unchangeable = log_default->type == SAY_LOGGER_BOOT || >  35 +`......`.......`.......    log_default->type == SAY_LOGGER_SYSLOG; >  36 +`......if (unchangeable) [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016121.html -- Best regards, IM