From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5C2854696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 12:26:56 +0300 (MSK)
Date: Fri, 17 Apr 2020 12:26:55 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200417092655.GC115@pony.bronevichok.ru>
References: <cover.1586849129.git.sergeyb@tarantool.org>
 <56290abaaa1850a223eac0fa7165bcb9f890501d.1586849129.git.sergeyb@tarantool.org>
 <20200415205102.GF8314@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200415205102.GF8314@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/6] Fix luacheck warnings in
	src/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

Igor, thanks for review!
See my answers below.

On 23:51 Wed 15 Apr , Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch!
> 
> On 14.04.20, Sergey Bronnikov wrote:
> > Many warnings fixed with help from Vladislav Shpilevoy.

<snipped>

> > diff --git a/src/lua/argparse.lua b/src/lua/argparse.lua
> > index faa0ae130..f58985425 100644
> > --- a/src/lua/argparse.lua
> > +++ b/src/lua/argparse.lua
> > @@ -90,8 +90,8 @@ local function convert_parameter(name, convert_from, convert_to)
> >      return convert_from
> >  end
> >  
> > -local function parameters_parse(t_in, options)
> > -    local t_out, t_in = {}, t_in or {}
> > +local function parameters_parse(t__in, options)
> > +    local t_out, t_in = {}, t__in or {}
> 
> I guess you can just give t__in a proper name, e.g. args, params, etc.

Agree with you, replaced it with 'param'.

<snipped>

> I see no reasons to leave other W212[unused argument self] occurences.
> Here is a diff:

Vladislav already told me in previous review iterations that '_' is less
readable than 'self', so it was a reason why haven't fixed them. I have
found a way to supress only W212 related to 'self' and applied it in
branch.

S.