From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7B92E4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 10:02:28 +0300 (MSK)
Date: Fri, 17 Apr 2020 10:02:27 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200417070227.kjdavtfhyaykfevf@tarantool.org>
References: <20200416120658.33777-1-sergepetrenko@tarantool.org>
 <20200416123802.GS3072@uranus> <20200416124240.GT3072@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200416124240.GT3072@uranus>
Subject: Re: [Tarantool-patches] [PATCH] relay: move
 relay_schedule_pending_gc before status
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hello,

On 16 апр 15:42, Cyrill Gorcunov wrote:
> On Thu, Apr 16, 2020 at 03:38:02PM +0300, Cyrill Gorcunov wrote:
> ...
> > > This code was present in v5 of the patchset regarding local space replication
> > > rework, but I accidentally threw it  away during the review. Sorry.
> > > The letter was "[PATCH v5 2/4] replication: hide 0-th vclock components in
> > > replication responses"
> > > 
> > > Branch:  https://github.com/tarantool/tarantool/tree/sp/relay-gc-fix
> > 
> > Maybe it worth to have two commits?
> > 
> >  - use vclock_compare_ignore0 in relay_schedule_pending_gc
> >  - reorder relay_schedule_pending_gc
> 
> Doesn't matter, already merged :)

I have no idea, why my mail wasn't sent.

Anyway, the patch was committed to master.

--
Regards, Kirill Yukhin