From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6958F4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 09:58:55 +0300 (MSK)
Date: Fri, 17 Apr 2020 09:58:54 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200417065854.yh2fiphl7l4zt6nt@tarantool.org>
References: <cover.1586862436.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1586862436.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 00/12] Popen Lua API: preliminary
 patches 2
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 14 апр 14:38, Alexander Turenko wrote:
> It is the second patchset of preparation patches that are needed to
> implement Lua API for popen.
> 
> See the previous series here (already pushed to master):
> https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/015609.html
> 
> https://github.com/tarantool/tarantool/issues/4031
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4031-popen-lua-api-preparation-2
> 
> I also pushed the same commit to *-full-ci branch to verify it on all
> platforms:
> 
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-4031-popen-lua-api-preparation-2-full-ci
> 
> Alexander Turenko (10):
>   popen: log a reason of close inherited fds failure
>   popen: add missed diag_set() in popen_new()
>   popen: remove retval from popen_stat()
>   popen: quote multiword command arguments
>   popen: add logging of duplicated logger fd
>   popen: fix close-on-exec flag setting
>   popen: clarify popen_{signal,delete} contract
>   popen: add FIXME re group signal flaw
>   popen: clarify popen_read_timeout error message
>   popen: allow to close parent's end of std* fds
> 
> Cyrill Gorcunov (2):
>   popen: allow to kill process group
>   popen: add ability to keep child on deletion
> 
>  src/lib/core/popen.c | 305 +++++++++++++++++++++++++++++++++----------
>  src/lib/core/popen.h |  17 ++-
>  2 files changed, 253 insertions(+), 69 deletions(-)

I've checked your patch into master.

--
Regards, Kirill Yukhin