From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2CAD54696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 01:04:17 +0300 (MSK)
Date: Thu, 16 Apr 2020 22:04:16 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200416220415.GC8455@tarantool.org>
References: <1b7ea654465f9a92cb0949ce6286fee63e2be1ca.1587063872.git.imeevma@gmail.com>
 <1587064169.460537645@f501.i.mail.ru>
 <20200416191851.GA8455@tarantool.org>
 <20200416202451.GA15068@tarantool.org>
 <20200416210205.GB8455@tarantool.org>
 <20200416211547.GA19535@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200416211547.GA19535@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] lua: fix test
 sql/func-recreate.test.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 17 Apr 00:15, Mergen Imeev wrote:
> On Thu, Apr 16, 2020 at 09:02:05PM +0000, Nikita Pettik wrote:
> > On 16 Apr 23:24, Mergen Imeev wrote:
> > > Hi! Thank you for review. My answer below.
> > > 
> > > On Thu, Apr 16, 2020 at 07:18:51PM +0000, Nikita Pettik wrote:
> > > > On 16 Apr 22:09, Alexander Tikhonov wrote:
> > > > > 
> > > > > Hi Mergen, thanks for the patch, I’ve checked it on 2.2 and it runs fine, patch LGTM.
> > > > > 
> > > > 
> > > > Did you verify that modified test still reproduces initial problem?
> > > > I hope so, but ask just in case.
> > > According to history, the main goal of this part of the
> > > test is to show that sql_create_function() throws proper
> > > error in case a new function is created when transaction
> > > is active. Since the error still here, we may say that
> > > the test works.
> > 
> > So the answer to my question is - no, you didn't test it.
> > Better safe than sorry - I'd better verify that updated
> > test still covers the initial problem. Thanks.
> > 
> Doesn't my answer says that we checked it?

No, it doesn't. 'reproduce' means that you are supposed to checkout
to branch, revert particular fix, run updated test without that fix
and verify that test fails without fix. Any other actions do not refer
to my original question.

>However, I agree that it is never wrong to check it again.

Please, check it for current fix and for any other test
upgrade in future.