From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5DB944696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Apr 2020 17:03:39 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id q22so8000277ljg.0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Apr 2020 07:03:39 -0700 (PDT)
Date: Thu, 16 Apr 2020 17:03:35 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200416140335.GU3072@uranus>
References: <20200411231034.95903-1-roman.habibov@tarantool.org>
 <20200412103721.GV3072@uranus>
 <0920770A-F34B-4874-A206-68E7A71D09EF@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0920770A-F34B-4874-A206-68E7A71D09EF@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] console: check on_shutdown() before
	exit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Wed, Apr 15, 2020 at 04:57:39AM +0300, Roman Khabibov wrote:
...
> 
> commit 6466cf42ae5755826af0c616243106a696da044a (HEAD -> romanhabibov/gh-4703_on_shutdown)
> Author: Roman Khabibov <roman.habibov@tarantool.org>
> Date:   Fri Apr 10 14:31:17 2020 +0300
> 
>     console: check on_shutdown() before exit
>     
>     Add check that on_shutdown() triggers were called before exit,
>     because in case of EOF or Ctrl+D (no signals) they were ignored.
>     
>     Closes #4703

Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>

Hopefully I didn't miss something obvious.