From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 55D0B4696C3 for ; Thu, 16 Apr 2020 15:42:42 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id r17so5487509lff.2 for ; Thu, 16 Apr 2020 05:42:42 -0700 (PDT) Date: Thu, 16 Apr 2020 15:42:40 +0300 From: Cyrill Gorcunov Message-ID: <20200416124240.GT3072@uranus> References: <20200416120658.33777-1-sergepetrenko@tarantool.org> <20200416123802.GS3072@uranus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416123802.GS3072@uranus> Subject: Re: [Tarantool-patches] [PATCH] relay: move relay_schedule_pending_gc before status List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On Thu, Apr 16, 2020 at 03:38:02PM +0300, Cyrill Gorcunov wrote: ... > > This code was present in v5 of the patchset regarding local space replication > > rework, but I accidentally threw it away during the review. Sorry. > > The letter was "[PATCH v5 2/4] replication: hide 0-th vclock components in > > replication responses" > > > > Branch: https://github.com/tarantool/tarantool/tree/sp/relay-gc-fix > > Maybe it worth to have two commits? > > - use vclock_compare_ignore0 in relay_schedule_pending_gc > - reorder relay_schedule_pending_gc Doesn't matter, already merged :)